-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align Physics system #318
Align Physics system #318
Conversation
1a7c9cb
to
e6989f2
Compare
It seems that there are few PRs upstream targeting the Physics system that will be merged upstream in the next few days. I'll leave this PR open for few more days, maybe I can include them here as well. |
I think this make sense, all of the Ignition is quite new so depending on the latest release make totally sense. |
In this PR, I also enabled the support to the profiler that could be helpful to debug #319. As soon as I start this task, I'll write a short tutorial in Discussions. In the meantime, let's refer to the upstream's documentation. |
Reminder for my future self. In 21c9233 I disabled some lines introduced in gazebosim/gz-sim#678 that were causing paused step to behave weird. Probably there's something strange in the caching of the link poses. Commenting out these lines and forcing the changed state in 4cab097 fixed the visualization. There's some upstream effort to run server and gui in the same process, as soon as they will implement it, network transport is no longer needed and these problems should not arise. VideoThis is a pure kinematic visualization where only paused steps are run. Without the mentioned fix, the visual of the feet do not work properly. feet_visual_weird.mp4Reminder: I have to squash and merge this time. |
More details about the broadcasting of the Pose components for paused steps implemented in 4cab097 can be found in gazebosim/gz-sim#544. |
Following the new procedure #315.
Note: this PR breaks the compatibility with Ignition distributions older than Edifice. Unfortunately, if we want to keep our current branching policy and keep the Physics system aligned with upstream, we cannot guarantee (as documented) backward compatibility with previous distributions.